[SPARK-35442][SQL] Support propagate empty relation through aggregate #35135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
The failed test is not related, also find in https://github.com/apache/spark/pull/35127. cc @cloud-fan |
Contributor
|
can you also address #32602 (comment) ? |
ulysses-you
commented
Jan 9, 2022
Contributor
Author
There was a problem hiding this comment.
A small bug fix, the previous is
Alias(newAttr, oldAttr.name)(oldAttr.exprId, explicitMetadata = newExplicitMetadata)
We should make alias use the not same expr id with references as the integral check do LogicalPlanIntegrity.checkIfExprIdsAreGloballyUnique.
ulysses-you
force-pushed
the
SPARK-35442
branch
from
c2f6be1 to
d73bfc0
Compare
ulysses-you
force-pushed
the
SPARK-35442
branch
from
d73bfc0 to
896e656
Compare
Contributor
Author
|
The GA seems broken due to unknown, move to #35149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
LogicalQueryStage(_, agg: BaseAggregateExec)check inAQEPropagateEmptyRelationLeafNodecheck inPropagateEmptyRelationBase, so we can eliminateLogicalQueryStagetoLocalRelationWhy are the changes needed?
The Aggregate in AQE is different with others, the
LogicalQueryStagelooks likeLogicalQueryStage(Aggregate, BaseAggregate). We should handle this case specially.Logically, if the Aggregate grouping expression is not empty, we can eliminate it safely.
Does this PR introduce any user-facing change?
no
How was this patch tested?
add new test