[SPARK-32307][FOLLOW-UP][SQL] Set outputEncoder to None for ScalaUDF.preCanonicalized #34937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Dec 17, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #146334 has finished for PR 34937 at commit
|
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to set
outputEncodertoNoneforScalaUDF.preCanonicalized.Why are the changes needed?
We once did the same thing to
inputEncodersin #29106 to fix a bug where the canonicalized ScalaUDFs for the same ScalaUDF becomes different after resolvinginputEncoders. So this PR applies the same fix tooutputEncoderto avoid hitting the same issue in the future. Note that we don't have the issue caused byoutputEncodernow since we don't resolveoutputEncoderyet.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass existing tests.