[SPARK-37589][SQL][TESTS] Improve the performance of PlanParserSuite
#34841
Conversation
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #146023 has finished for PR 34841 at commit
|
|
ping @cloud-fan |
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Could you give us some improvement numbers in the PR description, @beliefer ?
So we can reduce the time spent on executing PlanParserSuite by replace parsePlan.
dongjoon-hyun
changed the title
PlanParserSuitePlanParserSuite
| comparePlans(parsePlan(sqlCommand), plan, checkAnalysis = false) | ||
| } | ||
|
|
||
| private def assertQueryEqual(query: String, plan: LogicalPlan): Unit = { |
There was a problem hiding this comment.
This makes it hard to write tests as people need to pick between assertEqual and assertQueryEqual.
How much we can speed up this test suite by doing so?
There was a problem hiding this comment.
About tens of milliseconds
|
Maybe it not worth. |
|
Thank you for closing, @beliefer . |
4 participants
What changes were proposed in this pull request?
#34543 provides the parse method
parseQuery. So we can reduce the time spent on executingPlanParserSuiteby replaceparsePlan.Why are the changes needed?
Improve the performance of
PlanParserSuite.Does this PR introduce any user-facing change?
'No'.
Just update tests.
How was this patch tested?
Jenkins test.