[SPARK-37326][SQL][FOLLOWUP] Fix the test for Java 11 #34771
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Kubernetes integration test starting |
dongjoon-hyun
approved these changes
Dec 1, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. I verified locally too. Thank you, @sarutak .
|
Kubernetes integration test status failure |
|
Test build #145819 has finished for PR 34771 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes an issue that the test added in SPARK-37326 (#34596) fails with Java 11.
https://github.com/apache/spark/runs/4381645820?check_suite_focus=true#step:9:11681
The reason is that the error message
DateTimeFormatterwas changed as of Java 9.https://bugs.openjdk.java.net/browse/JDK-8085887
http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/28df1af8e872
Why are the changes needed?
To keep the build stable.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tests with the following command success.