Skip to content

[SPARK-37494][SQL] Unify v1 and v2 options output of SHOW CREATE TABLE command #34753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Peng-Lei wants to merge 1 commit into from
Closed

[SPARK-37494][SQL] Unify v1 and v2 options output of SHOW CREATE TABLE command #34753

Peng-Lei wants to merge 1 commit into from

Conversation

@Peng-Lei
Copy link
Contributor

@Peng-Lei Peng-Lei commented Nov 30, 2021

What changes were proposed in this pull request?

  1. Change the v1 SHOW CREATE TABLE command behaviors that options output match v2. eg:
    'key' = 'value'
  2. sort the order of options output.
  3. sort the order of properties output.

Why are the changes needed?

match v2 behaviors and disscuss at #comments

Does this PR introduce any user-facing change?

Yes. when SHOW CREATE TABLE the output of properties and options is sorted and options output is like 'key' = 'value'

How was this patch tested?

Add test case.

@github-actions github-actions bot added the SQL label Nov 30, 2021
@SparkQA
Copy link

SparkQA commented Nov 30, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50226/

@SparkQA
Copy link

SparkQA commented Nov 30, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50226/

@Peng-Lei
Copy link
Contributor Author

Peng-Lei commented Nov 30, 2021

@cloud-fan @MaxGekk Could you take a look? Thank you.

Peng-Lei
Peng-Lei commented Nov 30, 2021
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala Outdated
Copy link
Contributor Author

@Peng-Lei Peng-Lei Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep consistent with v2. also sort it.

Peng-Lei
Peng-Lei commented Nov 30, 2021
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala Outdated
Copy link
Contributor Author

@Peng-Lei Peng-Lei Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably has nothing to do with this PR.

@Peng-Lei Peng-Lei mentioned this pull request Nov 30, 2021
Closed
@SparkQA
Copy link

SparkQA commented Nov 30, 2021

Test build #145754 has finished for PR 34753 at commit 97e52cb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@Peng-Lei Peng-Lei force-pushed the v1-show-create-table branch from 97e52cb to 223e71e Compare December 1, 2021 08:17
@Peng-Lei Peng-Lei force-pushed the v1-show-create-table branch from 223e71e to 8ebf385 Compare December 1, 2021 09:12
@SparkQA
Copy link

SparkQA commented Dec 1, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50279/

@SparkQA
Copy link

SparkQA commented Dec 1, 2021

Test build #145805 has finished for PR 34753 at commit 223e71e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 1, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50283/

@SparkQA
Copy link

SparkQA commented Dec 1, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50279/

@SparkQA
Copy link

SparkQA commented Dec 1, 2021

Test build #145809 has finished for PR 34753 at commit 8ebf385.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 1, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50283/

@Peng-Lei Peng-Lei force-pushed the v1-show-create-table branch from 8ebf385 to 7771b14 Compare December 2, 2021 01:26
@SparkQA
Copy link

SparkQA commented Dec 2, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50308/

@SparkQA
Copy link

SparkQA commented Dec 2, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50308/

@cloud-fan
Copy link
Contributor

cloud-fan commented Dec 2, 2021

thanks, merging to master!

@cloud-fan cloud-fan closed this in b9b5562 Dec 2, 2021
@SparkQA
Copy link

SparkQA commented Dec 2, 2021

Test build #145833 has finished for PR 34753 at commit 7771b14.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@LuciferYang LuciferYang mentioned this pull request Oct 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloud-fan cloud-fan cloud-fan left review comments

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Peng-Lei @SparkQA @cloud-fan