[SPARK-37311][SQL] Migrate ALTER NAMESPACE ... SET LOCATION to use V2 command by default #34708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
Contributor
Author
|
cc @cloud-fan |
|
Kubernetes integration test status failure |
cloud-fan
approved these changes
Nov 25, 2021
Contributor
|
Thanks, merging to master! Happy Thanksgiving! |
|
Test build #145623 has finished for PR 34708 at commit
|
Contributor
Author
|
Thanks @cloud-fan for your help throughout the year! Happy Thanksgiving! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to use V2 commands as default as outlined in SPARK-36588, and this PR migrates
ALTER NAMESPACE ... SET LOCATIONto use v2 command by default.Note that the work to make v1/v2 commands consistent was done in #34686 and tests covering both v1/v2 were done in #34610.
Why are the changes needed?
It's been a while since we introduced the v2 commands, and it seems reasonable to use v2 commands by default even for the session catalog, with a legacy config to fall back to the v1 commands.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing *AlterNamespaceSetLocationSuite tests cover this PR's change.