-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-35672][FOLLOWUP][TESTS] Add an exclusion rule to MimaExcludes.scala for Scala 2.13. #34649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @sarutak for taking care of this. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Thank you @sarutak ! |
|
Test build #145398 has finished for PR 34649 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @sarutak .
This PR itself seems to pass MiMa.
BTW, when I rebased to the master, it seems that there is another issue.
|
Merged to master. |
Oh, O.K, I'll check it. |
…es.scala for Scala 2.13 ### What changes were proposed in this pull request? This PR adds more MiMa exclusion rules for Scala 2.13. #34649 partially resolved the compatibility issue but additional 3 compatibility problems are raised. ``` $ build/sbt clean $ dev/change-scala-version.sh 2.13 $ build/sbt -Pscala-2.13 clean $ dev/mima ... [error] spark-core: Failed binary compatibility check against org.apache.spark:spark-core_2.13:3.2.0! Found 3 potential problems (filtered 910) [error] * synthetic method copy$default$8()scala.collection.mutable.ListBuffer in class org.apache.spark.executor.CoarseGrainedExecutorBackend#Arguments has a different result type in current version, where it is scala.Option rather than scala.collection.mutable.ListBuffer [error] filter with: ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.executor.CoarseGrainedExecutorBackend#Arguments.copy$default$8") [error] * synthetic method copy$default$9()scala.Option in class org.apache.spark.executor.CoarseGrainedExecutorBackend#Arguments has a different result type in current version, where it is Int rather than scala.Option [error] filter with: ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.executor.CoarseGrainedExecutorBackend#Arguments.copy$default$9") [error] * the type hierarchy of object org.apache.spark.executor.CoarseGrainedExecutorBackend#Arguments is different in current version. Missing types {scala.runtime.AbstractFunction10} [error] filter with: ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.executor.CoarseGrainedExecutorBackend$Arguments$") ... ``` ### Why are the changes needed? To keep the build stable. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Confirmed MiMa passed. ``` $ build/sbt clean $ dev/change-scala-version.sh 2.13 $ build/sbt -Pscala-2.13 clean $ dev/mima Closes #34664 from sarutak/followup-SPARK-35672-mima-take2. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]>
What changes were proposed in this pull request?
This PR mitigate an issue that MiMa fails for Scala 2.13 after SPARK-35672 (#34120).
It's funny that the class
Argumentsispublicbut it's a member class ofCoarseGrainedExecutorBackendwhich ispackage privateand MiMa doesn't raise error for Scala 2.12, but adding an exclusion rule is one workaround.Why are the changes needed?
To keep the build stable.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Confirmed MiMa passed.