Skip to content

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Oct 23, 2021

What changes were proposed in this pull request?

This PR proposes to switch from Maven to SBT to build Spark on AppVeyor.

Why are the changes needed?

Recently, building Spark on AppVeyor almost always fails due to StackOverflowError at compile time.
We can't identify the reason so far but one workaround would be building with SBT.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

AppVeyor itself.

}

# ========================== Maven
# Push-Location $tools
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just comment out the instructions for installing Maven so that we can easily switch back to Maven after the StackOverflowError is resolved.

@SparkQA
Copy link

SparkQA commented Oct 24, 2021

Test build #144561 has finished for PR 34373 at commit 308f3c1.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 24, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49032/

@SparkQA
Copy link

SparkQA commented Oct 24, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49032/

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow this is super nice. Thanks @sarutak

@HyukjinKwon
Copy link
Member

Merged to master!!

@HyukjinKwon
Copy link
Member

Oops my mistake. I thought all build passed. Let me revert this one.

@HyukjinKwon HyukjinKwon reopened this Oct 24, 2021
@SparkQA
Copy link

SparkQA commented Oct 24, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49033/

@SparkQA
Copy link

SparkQA commented Oct 24, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49033/

@SparkQA
Copy link

SparkQA commented Oct 24, 2021

Test build #144562 has finished for PR 34373 at commit de150e4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 24, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49034/

@SparkQA
Copy link

SparkQA commented Oct 24, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49034/

@SparkQA
Copy link

SparkQA commented Oct 24, 2021

Test build #144563 has finished for PR 34373 at commit 4794a92.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants