Skip to content

[SPARK-37091][R] SystemRequirements to include Java < 18 #34371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bidek56 wants to merge 6 commits into from
Closed

[SPARK-37091][R] SystemRequirements to include Java < 18 #34371

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
581f075
Upgrading SystemRequirements to include Java <= 17
Oct 22, 2021
3b3c426
[SPARK-37084][SQL] Set spark.sql.files.openCostInBytes to bytesConf
RabbidHY Oct 23, 2021
700b8c0
Upgrading SystemRequirements to include Java <= 17
Oct 22, 2021
5c5000e
Merge branch 'SPARK-37091' of github.com:Bidek56/spark into SPARK-37091
Oct 23, 2021
da7f81b
[SPARK-37091][R] SystemRequirements to be Java < 18
Oct 23, 2021
0ef0e93
Revert "[SPARK-37084][SQL] Set spark.sql.files.openCostInBytes to byt…
Bidek56 Oct 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/pkg/DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Authors@R: c(person("Shivaram", "Venkataraman", role = "aut",
License: Apache License (== 2.0)
URL: https://www.apache.org https://spark.apache.org
BugReports: https://spark.apache.org/contributing.html
SystemRequirements: Java (>= 8, < 12)
SystemRequirements: Java (>= 8, < 18)
Depends:
R (>= 3.5),
methods
Expand Down
2 changes: 2 additions & 0 deletions core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ class ConfigEntrySuite extends SparkFunSuite {
assert(conf.get(bytes) === 1024L)
conf.set(bytes.key, "1k")
assert(conf.get(bytes) === 1L)
conf.set(bytes.key, "2048")
assert(conf.get(bytes) === 2048)
}

test("conf entry: regex") {
Expand Down
4 changes: 2 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1419,8 +1419,8 @@ object SQLConf {
" bigger files (which is scheduled first). This configuration is effective only when using" +
" file-based sources such as Parquet, JSON and ORC.")
.version("2.0.0")
.longConf
.createWithDefault(4 * 1024 * 1024)
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("4MB")

val FILES_MIN_PARTITION_NUM = buildConf("spark.sql.files.minPartitionNum")
.doc("The suggested (not guaranteed) minimum number of split file partitions. " +
Expand Down