Skip to content

[SPARK-37049][K8S] executorIdleTimeout should check creationTimestamp instead of startTime #34319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yangwwei wants to merge 4 commits into from
Closed

[SPARK-37049][K8S] executorIdleTimeout should check creationTimestamp instead of startTime #34319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b00ee44
[SPARK-37049] executorIdleTimeout is not working for pending pods on …
yangwwei Oct 18, 2021
8b03630
address review comments
yangwwei Oct 19, 2021
ec98190
rename val name to creationTime
yangwwei Oct 19, 2021
2ce8510
minor text change
yangwwei Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...es/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,11 +456,11 @@ class ExecutorPodsAllocator(

private def isExecutorIdleTimedOut(state: ExecutorPodState, currentTime: Long): Boolean = {
try {
val startTime = Instant.parse(state.pod.getStatus.getStartTime).toEpochMilli()
currentTime - startTime > executorIdleTimeout
val creationTime = Instant.parse(state.pod.getMetadata.getCreationTimestamp).toEpochMilli()
currentTime - creationTime > executorIdleTimeout
} catch {
case _: Exception =>
logDebug(s"Cannot get startTime of pod ${state.pod}")
case e: Exception =>
logError(s"Cannot get the creationTimestamp of the pod: ${state.pod}", e)
true
}
}
Expand Down
4 changes: 3 additions & 1 deletion ...re/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorLifecycleTestUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,11 @@ object ExecutorLifecycleTestUtils {

def pendingExecutor(executorId: Long, rpId: Int = DEFAULT_RESOURCE_PROFILE_ID): Pod = {
new PodBuilder(podWithAttachedContainerForId(executorId, rpId))
.editOrNewMetadata()
.withCreationTimestamp(Instant.now.toString)
.endMetadata()
.editOrNewStatus()
.withPhase("pending")
.withStartTime(Instant.now.toString)
.endStatus()
.build()
}
Expand Down