[WIP][SPARK-37012][PYTHON] Disable pinned thread mode by default #34288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #144285 has finished for PR 34288 at commit
|
Member
Author
|
it will be fixed via upgrading Py4J. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR reverts #32429 and disables pinned thread mode by default.
Although I made a fix in Py4J at py4j/py4j#440, we might have to disable it to be more conservative.
NOTE: I am still investigating if we will keep it enabled or disabled therefore I mark it as WIP for now.
Why are the changes needed?
To prevent regressions in notebooks such as Jupyter, see also SPARK-37004.
Does this PR introduce any user-facing change?
Yes, pinned thread mode is disabled by default.
How was this patch tested?
Existing tests should cover.