Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec… #34088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utors using config instead of command line" This reverts commit 866df69.
Member
Author
|
This is for branch-3.2 and branch-3.1 |
HyukjinKwon
approved these changes
Sep 24, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
Member
|
|
HyukjinKwon
pushed a commit
that referenced
this pull request
Sep 24, 2021
…utors using config instead of command line" ### What changes were proposed in this pull request? This reverts commit 866df69. ### Why are the changes needed? After the change environment variables were not substituted in user classpath entries. Please find an example on SPARK-35672. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes #34088 from gengliangwang/revertSPARK-35672. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Member
|
for 3.1, I will directly revert b4916d4 |
|
Test build #143579 has finished for PR 34088 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…utors using config instead of command line"
What changes were proposed in this pull request?
This reverts commit 866df69.
Why are the changes needed?
After the change environment variables were not substituted in user classpath entries. Please find an example on SPARK-35672.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.