[SPARK-36834][SHUFFLE] Add support for namespacing log lines emitted by external shuffle service #34079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
mridulm
reviewed
Sep 23, 2021
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
Outdated
Show resolved
Hide resolved
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
Outdated
Show resolved
Hide resolved
Contributor
|
+CC @tgravescs, @Ngone51 |
dongjoon-hyun
changed the title
thejdeep
force-pushed
the
SPARK-36834
branch
2 times, most recently
from
c85599f to
59cdb03
Compare
tgravescs
reviewed
Sep 23, 2021
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
Outdated
Show resolved
Hide resolved
Contributor
|
conceptually looks fine to me too. |
xkrogen
suggested changes
Sep 24, 2021
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
Outdated
Show resolved
Hide resolved
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
Outdated
Show resolved
Hide resolved
Contributor
Author
thejdeep
force-pushed
the
SPARK-36834
branch
2 times, most recently
from
c13c3a2 to
d0380ec
Compare
mridulm
reviewed
Oct 4, 2021
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
Outdated
Show resolved
Hide resolved
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
Outdated
Show resolved
Hide resolved
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
Outdated
Show resolved
Hide resolved
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
Outdated
Show resolved
Hide resolved
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
Outdated
Show resolved
Hide resolved
thejdeep
force-pushed
the
SPARK-36834
branch
2 times, most recently
from
d432baa to
6c754cf
Compare
Contributor
Author
|
@tgravescs @mridulm @xkrogen Addressed the comments, please review. Thanks |
xkrogen
suggested changes
Oct 5, 2021
Contributor
xkrogen
left a comment
xkrogen
left a comment
There was a problem hiding this comment.
Logic itself LGTM, I think having the base static logger which we later override is a good approach
I think we can make the documentation/messages a bit more user friendly
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
Outdated
Show resolved
Hide resolved
mridulm
reviewed
Oct 5, 2021
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
Outdated
Show resolved
Hide resolved
xkrogen
suggested changes
Oct 12, 2021
Contributor
xkrogen
left a comment
xkrogen
left a comment
There was a problem hiding this comment.
LGTM except for minor formatting comment
Contributor
Author
|
@mridulm @tgravescs Please take a look, thanks! |
mridulm
reviewed
Oct 14, 2021
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
Outdated
Show resolved
Hide resolved
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
Outdated
Show resolved
Hide resolved
mridulm
approved these changes
Oct 14, 2021
Contributor
mridulm
left a comment
mridulm
left a comment
There was a problem hiding this comment.
+CC @tgravescs, @xkrogen
Contributor
|
Ok to test |
|
Test build #144271 has finished for PR 34079 at commit
|
|
Kubernetes integration test starting |
…by ESS ### What changes were proposed in this pull request? Added a config `spark.yarn.shuffle.service.logs.namespace` which can be used to add a namespace suffix to log lines emitted by the External Shuffle Service. ### Why are the changes needed? Since many instances of ESS can be running on the same NM, it would be easier to distinguish between them. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? N/A
|
Test build #144272 has finished for PR 34079 at commit
|
|
Kubernetes integration test status failure |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added a config
spark.yarn.shuffle.service.logs.namespacewhich can be used to add a namespace suffix to log lines emitted by the External Shuffle Service.Why are the changes needed?
Since many instances of ESS can be running on the same NM, it would be easier to distinguish between them.
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A