-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-36683][SQL] Add new built-in SQL functions: SEC and CSC #33988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e60f6a1
Add new built-in SQL functions: SEC and CSC
48b3247
Add tests to MathExpressionSuite.scala
9ce80cb
add test results in operators.sql.out
068432b
added test to MathFunctionsSuite and fixed operators.sql
105631e
Merge branch 'SPARK-36683' of https://github.com/yutoacts/spark into …
abc64b6
re-generate operators.sql.out and fix MathFunctionSuite
937a3c8
Merge branch 'master' of https://github.com/apache/spark into SPARK-3…
0b808e2
Merge branch 'SPARK-36683' of https://github.com/yutoacts/spark into …
e0e90a1
add unit test in test_functions.py and generate golden result file
47f8fe2
add JIRA reference to test_functions.py
90d1f4e
Merge branch 'SPARK-36683' of https://github.com/yutoacts/spark into …
6454b2c
Moved duplicated functions from test_functions.py to sqlutils.py
9bc8d5f
fixed test_functions.py
f0b0887
add short descriptions in functions.py
2df5825
fixed lint error and wrong method calling
bf2179a
removed unnecessary spaces
a67b93f
edit assert_close in sqlutils.py: support negative infinity
0578140
"not math.isinf" to "math.isfinite" in assert_close
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -299,6 +299,7 @@ def column(col: str) -> Column: ... | |
| def cos(col: ColumnOrName) -> Column: ... | ||
| def cosh(col: ColumnOrName) -> Column: ... | ||
| def cot(col: ColumnOrName) -> Column: ... | ||
| def csc(col: ColumnOrName) -> Column: ... | ||
|
||
| def count(col: ColumnOrName) -> Column: ... | ||
| def cume_dist() -> Column: ... | ||
| def degrees(col: ColumnOrName) -> Column: ... | ||
|
|
@@ -337,6 +338,7 @@ def rank() -> Column: ... | |
| def rint(col: ColumnOrName) -> Column: ... | ||
| def row_number() -> Column: ... | ||
| def rtrim(col: ColumnOrName) -> Column: ... | ||
| def sec(col: ColumnOrName) -> Column: ... | ||
| def signum(col: ColumnOrName) -> Column: ... | ||
| def sin(col: ColumnOrName) -> Column: ... | ||
| def sinh(col: ColumnOrName) -> Column: ... | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add a short description?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, just added a description to all trig functions that missed it.