-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-36702][SQL] ArrayUnion handle duplicated Double.NaN and Float.Nan #33951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ping @cloud-fan |
|
Kubernetes integration test starting |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Kubernetes integration test status failure |
|
Test build #143136 has finished for PR 33951 at commit
|
|
Test build #143137 has finished for PR 33951 at commit
|
|
How does this differ from #33955 ? |
|
Mind elabourating #33951 (comment)? Also let's keep one PR only for the issue if we're clear on which approach to go ahead for. |
Close this, you can go ahead on that pr. |
What changes were proposed in this pull request?
For query
This returns [NaN, NaN], but it should return [NaN].
This issue is caused by
OpenHashSetcan't handleDouble.NaNandFloat.NaNtoo.In this pr we handle
NaNlikeNullvalueWhy are the changes needed?
Fix bug
Does this PR introduce any user-facing change?
ArrayUnion won't show duplicated
NaNvalueHow was this patch tested?
Added UT