[SPARK-36688][R] Add cot as an R function #33925
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hyukjin Kwon <[email protected]>
|
Can one of the admins verify this patch? |
HyukjinKwon
reviewed
Sep 7, 2021
| #' @rdname column_math_functions | ||
| #' @aliases cot cot,Column-method | ||
| #' @note cot since 3.3.0 | ||
| setMethod("cot", |
Member
There was a problem hiding this comment.
I think you should also add it into R/pkg/R/generics.R, and add a simple test at R/pkg/tests/fulltests/test_sparkSQL.R.
Also, let's create a separate JIRA for this one.
Contributor
Author
There was a problem hiding this comment.
Thanks, just added.
So, if I add a new function, should I make a JIRA ticket and PR separately just for R implementation?
yutoacts
changed the title
HyukjinKwon
approved these changes
Sep 8, 2021
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add cotangent as an R function.
Why are the changes needed?
My previous PR (#33906) missed R support.
Does this PR introduce any user-facing change?
Yes, users can now call the cotangent function as an R function.
How was this patch tested?
unit tests.