Skip to content

Conversation

@Peng-Lei
Copy link
Contributor

@Peng-Lei Peng-Lei commented Aug 27, 2021

What changes were proposed in this pull request?

Mark the exception added private[spark]
according comments

Why are the changes needed?

comments

Does this PR introduce any user-facing change?

No

How was this patch tested?

existed ut testcase

@Peng-Lei Peng-Lei changed the title [SPARK-36336][SQL][FOLLOWUP] Make exception private[spark] [SPARK-36336][SQL][FOLLOWUP] Mark exception private[spark] Aug 27, 2021
@github-actions github-actions bot added the CORE label Aug 27, 2021
@dongjoon-hyun
Copy link
Member

cc @cloud-fan and @HyukjinKwon

@gengliangwang
Copy link
Member

Do we need to make SparkException private as well, regarding the comment #33824 (comment)

cc @karenfeng

@cloud-fan
Copy link
Contributor

SparkException is not newly added, I'm a bit worried about changing it.

@gengliangwang
Copy link
Member

SparkException is not newly added, I'm a bit worried about changing it.

Right, let's leave it as it is.

@cloud-fan
Copy link
Contributor

ok to test

@SparkQA
Copy link

SparkQA commented Aug 27, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47336/

@SparkQA
Copy link

SparkQA commented Aug 27, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47336/

@SparkQA
Copy link

SparkQA commented Aug 27, 2021

Test build #142834 has finished for PR 33856 at commit d59ccd7.

  • This patch fails from timeout after a configured wait of 500m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Aug 29, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47347/

@SparkQA
Copy link

SparkQA commented Aug 29, 2021

Test build #142845 has finished for PR 33856 at commit d59ccd7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Aug 30, 2021

Merged to master.

@Peng-Lei Peng-Lei deleted the SPARK-36336-FOLLOW branch August 30, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants