[SPARK-36594][SQL][3.2] ORC vectorized reader should properly check maximal number of fields #33843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @cloud-fan, thanks. |
cloud-fan
approved these changes
Aug 26, 2021
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
Contributor
|
thanks, merging to 3.2! |
cloud-fan
pushed a commit
that referenced
this pull request
Aug 26, 2021
…aximal number of fields ### What changes were proposed in this pull request? This is the patch on branch-3.2 for #33842. See the description in the other PR. ### Why are the changes needed? Avoid OOM/performance regression when reading ORC table with nested column types. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added unit test in `OrcSourceSuite.scala`. Closes #33843 from c21/branch-3.2. Authored-by: Cheng Su <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
|
Test build #142781 has finished for PR 33843 at commit
|
Contributor
Author
|
Thank you @cloud-fan for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is the patch on branch-3.2 for #33842. See the description in the other PR.
Why are the changes needed?
Avoid OOM/performance regression when reading ORC table with nested column types.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added unit test in
OrcSourceSuite.scala.