Skip to content

Conversation

@gengliangwang
Copy link
Member

What changes were proposed in this pull request?

This is follow-up of #31522.
It adds docs for the new metrics of task/job commit time

Why are the changes needed?

So that users can understand the metrics better and know that the new metrics are only for file table writes.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Build docs and preview:
image

@gengliangwang
Copy link
Member Author

cc @AngersZhuuuu @cloud-fan

@github-actions github-actions bot added the DOCS label Jul 27, 2021
@SparkQA
Copy link

SparkQA commented Jul 27, 2021

Test build #141722 has finished for PR 33542 at commit d218b44.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 27, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46235/

@SparkQA
Copy link

SparkQA commented Jul 27, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46235/

Copy link
Contributor

@AngersZhuuuu AngersZhuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloud-fan
Copy link
Contributor

thanks, merging to master/3.2!

@cloud-fan cloud-fan closed this in c9a7ff3 Jul 28, 2021
cloud-fan pushed a commit that referenced this pull request Jul 28, 2021
…b commit time

### What changes were proposed in this pull request?

This is follow-up of #31522.
It adds docs for the new metrics of task/job commit time

### Why are the changes needed?

So that users can understand the metrics better and know that the new metrics are only for file table writes.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Build docs and preview:
![image](https://user-images.githubusercontent.com/1097932/127198210-2ab201d3-5fca-4065-ace6-0b930390380f.png)

Closes #33542 from gengliangwang/addDocForMetrics.

Authored-by: Gengliang Wang <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
(cherry picked from commit c9a7ff3)
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants