Skip to content

[SPARK-36273][Shuffle] Fix identical values comparison #33493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
almogtavor wants to merge 1 commit into from
Closed

[SPARK-36273][Shuffle] Fix identical values comparison #33493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FinalizeShuffleMerge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public boolean equals(Object other) {
if (other != null && other instanceof FinalizeShuffleMerge) {
FinalizeShuffleMerge o = (FinalizeShuffleMerge) other;
return Objects.equal(appId, o.appId)
&& appAttemptId == appAttemptId
&& appAttemptId == o.appAttemptId
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jul 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was introduced via https://github.com/apache/spark/pull/33078/files#diff-a4d872ac22f3cbdfb587125ee9dc4c70fe9efca58e3de5b31dad227f689046f9R71 which landed at master/3.2 4 days ago.

So, we don't need this at branch-3.1.

&& shuffleId == o.shuffleId;
}
return false;
Expand Down