[SQL][MINOR] EquivalentExpressions.commonChildrenToRecurse should skip CodegenFallback #33304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
approved these changes
Jul 12, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Sorry, but could you avoid using MINOR, @cloud-fan ? It's not clear to the other reviewers.
- What did cause this bug?
- Does this affect the released Apache Spark?
- When does this happen from?
Contributor
Author
|
This is so minor that I opened this backport PR only because someone asked for it. I think the mistake was there since this piece of code was added. I didn't look into how this affects real queries and what is the consequence, as this mistake is so obvious. There is no bug report so far. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #140930 has finished for PR 33304 at commit
|
dongjoon-hyun
approved these changes
Jul 13, 2021
Member
|
Merged to branch-3.1. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 13, 2021
…p CodegenFallback ### What changes were proposed in this pull request? This is a very trivial mistake we found during a code refactor in https://github.com/apache/spark/pull/33142/files#r660900049 This PR backport this one-line fix. ### Why are the changes needed? fix a mistake ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests Closes #33304 from cloud-fan/backport. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
…p CodegenFallback ### What changes were proposed in this pull request? This is a very trivial mistake we found during a code refactor in https://github.com/apache/spark/pull/33142/files#r660900049 This PR backport this one-line fix. ### Why are the changes needed? fix a mistake ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests Closes apache#33304 from cloud-fan/backport. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
fishcus
pushed a commit
to fishcus/spark
that referenced
this pull request
Jan 12, 2022
…p CodegenFallback ### What changes were proposed in this pull request? This is a very trivial mistake we found during a code refactor in https://github.com/apache/spark/pull/33142/files#r660900049 This PR backport this one-line fix. ### Why are the changes needed? fix a mistake ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests Closes apache#33304 from cloud-fan/backport. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a very trivial mistake we found during a code refactor in https://github.com/apache/spark/pull/33142/files#r660900049
This PR backport this one-line fix.
Why are the changes needed?
fix a mistake
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests