Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Jul 2, 2021

What changes were proposed in this pull request?

This patch ignores the test "ensure that concurrent update and cleanup consistent versions" in #32933. The test is currently flaky and we will address it later.

Why are the changes needed?

Unblock other developments.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests.

@viirya
Copy link
Member Author

viirya commented Jul 2, 2021

cc @dongjoon-hyun

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that is a test only issue, I'm +1.
BTW, let's keep the issue open although we merge this.

@viirya
Copy link
Member Author

viirya commented Jul 2, 2021

Thanks @dongjoon-hyun!

Yea, I reuse original JIRA with followup only.

@xuanyuanking will address SPARK-35993 by fixing the test later.

And yes, this is test only issue.

@dongjoon-hyun
Copy link
Member

Oh, perfect, @viirya !

Yea, I reuse original JIRA with followup only.

dongjoon-hyun pushed a commit that referenced this pull request Jul 2, 2021
### What changes were proposed in this pull request?

This patch ignores the test "ensure that concurrent update and cleanup consistent versions" in #32933. The test is currently flaky and we will address it later.

### Why are the changes needed?

Unblock other developments.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Existing tests.

Closes #33195 from viirya/ignore-rocksdb-test.

Authored-by: Liang-Chi Hsieh <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit a6e00ee)
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun
Copy link
Member

Merged to master/3.1.

@SparkQA
Copy link

SparkQA commented Jul 2, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45101/

@viirya
Copy link
Member Author

viirya commented Jul 2, 2021

Thanks @dongjoon-hyun

@SparkQA
Copy link

SparkQA commented Jul 2, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45101/

@SparkQA
Copy link

SparkQA commented Jul 2, 2021

Test build #140590 has finished for PR 33195 at commit 55da54c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya viirya deleted the ignore-rocksdb-test branch December 27, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants