[SPARK-33298][CORE][FOLLOWUP] Add Unstable annotation to FileCommitProtocol
#33148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @HyukjinKwon and @cloud-fan please take a look when you have time, thanks. |
HyukjinKwon
reviewed
Jun 30, 2021
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
approved these changes
Jun 30, 2021
c21
changed the title
FileCommitProtocolFileCommitProtocol
HyukjinKwon
reviewed
Jun 30, 2021
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
approved these changes
Jun 30, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
Member
|
Merged to master. |
|
Test build #140424 has finished for PR 33148 at commit
|
Contributor
Author
|
Thank you @HyukjinKwon and @dongjoon-hyun for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is the followup from #33012 (comment), where we want to add
@UnstabletoFileCommitProtocol, to give people a better idea of API.Why are the changes needed?
Make it easier for people to follow and understand code. Clean up code.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit tests, as no real logic change.