Skip to content

[SPARK-35733][SQL][TESTS] Check all day-time interval types in HiveInspectors tests #33036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AngersZhuuuu wants to merge 2 commits into from
Closed

[SPARK-35733][SQL][TESTS] Check all day-time interval types in HiveInspectors tests #33036

AngersZhuuuu wants to merge 2 commits into from

Conversation

@AngersZhuuuu
Copy link
Contributor

@AngersZhuuuu AngersZhuuuu commented Jun 23, 2021 •
edited by MaxGekk
Loading

What changes were proposed in this pull request?

Check all day-time interval types in HiveInspectors tests.

Why are the changes needed?

New tests should improve test coverage for day-time interval types.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Added UT.

@AngersZhuuuu
Copy link
Contributor Author

AngersZhuuuu commented Jun 23, 2021

FYI @MaxGekk

@github-actions github-actions bot added the SQL label Jun 23, 2021
@SparkQA
Copy link

SparkQA commented Jun 23, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44713/

@SparkQA
Copy link

SparkQA commented Jun 23, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44713/

@MaxGekk MaxGekk changed the title [SPARK-35733][SQL][TEST] Check all day-time interval types in HiveInspectors tests [SPARK-35733][SQL][TESTS] Check all day-time interval types in HiveInspectors tests Jun 23, 2021
MaxGekk
MaxGekk reviewed Jun 23, 2021
View reviewed changes
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala Outdated
}

test("SPARK-34879: HiveInspectors supports DayTimeIntervalType") {
test("SPARK-35733: HiveInspectors supports supports all type of DayTimeIntervalType") {
Copy link
Member

@MaxGekk MaxGekk Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add both: test("SPARK-34879, SPARK-35733:

Copy link
Contributor Author

@AngersZhuuuu AngersZhuuuu Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

AngersZhuuuu
AngersZhuuuu commented Jun 23, 2021
View reviewed changes
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala
}

test("SPARK-35722: HiveInspectors supports all type of YearMonthIntervalType") {
test("SPARK-34879, SPARK-35722: HiveInspectors supports all type of YearMonthIntervalType") {
Copy link
Contributor Author

@AngersZhuuuu AngersZhuuuu Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaxGekk Also update here

@SparkQA
Copy link

SparkQA commented Jun 23, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44720/

@SparkQA
Copy link

SparkQA commented Jun 23, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44720/

@SparkQA
Copy link

SparkQA commented Jun 23, 2021

Test build #140193 has finished for PR 33036 at commit efbd730.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 23, 2021

Test build #140186 has finished for PR 33036 at commit 6e8f33a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

MaxGekk
MaxGekk approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@MaxGekk MaxGekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merging to master.
Thank you, @AngersZhuuuu .

@MaxGekk MaxGekk closed this in 077cf2a Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxGekk MaxGekk MaxGekk approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AngersZhuuuu @SparkQA @MaxGekk