[SPARK-30993][FOLLOWUP][SQL] Refactor LocalDateTimeUDT as YearUDT in UserDefinedTypeSuite #32824
Conversation
| } | ||
|
|
||
| UDTRegistration.register(classOf[LocalDateTime].getName, classOf[LocalDateTimeUDT].getName) | ||
| UDTRegistration.register(classOf[Year].getName, classOf[YearUDT].getName) |
There was a problem hiding this comment.
shall we unregister it after test finishes?
There was a problem hiding this comment.
oh there is no such API yet...
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
Test build #139500 has finished for PR 32824 at commit
|
|
Merging to master |
|
Hi, @gengliangwang . I'm not aware of the community rule for this. However, usually, I use a follow-up style when they will have the same release version which means the original patch is not released yet. |
|
@dongjoon-hyun Yes, I think creating a new Jira makes more sense. Thanks for the suggestion! |
4 participants
What changes were proposed in this pull request?
Refactor LocalDateTimeUDT as YearUDT in UserDefinedTypeSuite
Why are the changes needed?
As we are going to support java.time.LocalDateTime as an external type of TimestampWithoutTZ type #32814, registering java.time.LocalDateTime as UDT will cause test failures: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139469/testReport/
This PR is to unblock #32814.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.