Skip to content

[SPARK-35439][SQL] Children subexpr should come first than parent subexpr #32586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 8 commits into from
Closed

[SPARK-35439][SQL] Children subexpr should come first than parent subexpr #32586

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7b6b589
Use LinkedHashMap to guarantee traversing with the order they were in…
viirya May 19, 2021
f777855
fix
viirya May 18, 2021
71b67cb
Add more comment.
viirya May 19, 2021
55bc9ec
Rename ordering class and add more comment.
viirya May 19, 2021
c143ce2
Revert back to HashMap.
viirya May 19, 2021
b517df8
Update sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expr…
viirya May 20, 2021
b13bc65
sort after filtering.
viirya May 20, 2021
3819bf3
Merge branch 'use-listhashmap' of github.com:viirya/spark-1 into use-…
viirya May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...lyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class EquivalentExpressions {
}

// For each expression, the set of equivalent expressions.
private val equivalenceMap = mutable.HashMap.empty[Expr, mutable.ArrayBuffer[Expression]]
private val equivalenceMap = mutable.LinkedHashMap.empty[Expr, mutable.ArrayBuffer[Expression]]

@cloud-fan cloud-fan May 19, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the new change, does it still need to be LinkedHashMap?

@viirya viirya May 19, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, can be reverted back to HashMap, if we are going to sort it at all.


/**
* Adds each expression to this data structure, grouping them with existing equivalent
Expand Down