[SPARK-35048][INFRA] Only trigger the notify test workflow in upstream#32174
[SPARK-35048][INFRA] Only trigger the notify test workflow in upstream#32174Yikun wants to merge 1 commit intoapache:masterfrom
Conversation
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #749253407 for PR 32174 at commit |
|
Test build #137368 has finished for PR 32174 at commit
|
| - name: "Notify test workflow" | ||
| uses: actions/github-script@v3 | ||
| if: ${{ github.base_ref == 'master' }} | ||
| if: github.base_ref == 'master' && github.repository == 'apache/spark' |
There was a problem hiding this comment.
@Yikun so is the problem that the "Notify test workflow" is triggered in the forked repository's PRs too? I think it's not a big problem but okay.
There was a problem hiding this comment.
oops, I am wrong to thought that the fork repo "Notify test workflow" will create a new series workflow, but actually, the notify test workflow just found the job and give the link.
So, as you said, this pr only skip the notify process.
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Looks good but can you create a separate JIRA for this please @Yikun?
|
Ohh actually this will disable a case when another person creates a PR against somebody's fork e.g.) HyukjinKwon#35. It happens time to time when you work together. Let's just drop it for now. |
|
Yep |
3 participants
What changes were proposed in this pull request?
Only trigger the notify test workflow in upstream
Why are the changes needed?
We should only trigger the notify test workflow in upstream apache/spark job, otherwise we will trigger the same workflow twice in fork repos.
Does this PR introduce any user-facing change?
No
How was this patch tested?
See local test in Yikun#13,
The notify test is skiped in fork repo.
https://github.com/Yikun/spark/pull/13/checks?check_run_id=2345776215
Note that current notify_test_workflow with pull_request_target event doesn't use something like
action/checkoutto checkout code. So this skip will only effect when this patch is merged, I just use change thepull_request_targetthepull requestto do local test.