[SPARK-35016][SQL] Format ANSI intervals in Hive style #32120
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
IntervalUtilsmethods:toYearMonthIntervalStringandtoDayTimeIntervalStringto support formatting of year-month/day-time intervals in Hive style. The methods get new parameter style which can have to values;HIVE_STYLEandANSI_STYLE.toYearMonthIntervalStringandtoDayTimeIntervalStringfrom theCastexpression with thestyleparameter is set toANSI_STYLE.toYearMonthIntervalStringandtoDayTimeIntervalStringfromHiveResultwithstyleis set toHIVE_STYLE.Why are the changes needed?
The
spark-sqlshell formats its output in Hive style by usingHiveResult.hiveResultString(). The changes are needed to match Hive behavior. For instance,Hive:
Spark before the changes:
Also this should unblock #32099 which enables *.sql tests in
SQLQueryTestSuite.Does this PR introduce any user-facing change?
Yes. After the changes:
How was this patch tested?
IntervalUtilsSuite:HiveResultSuite: