[SPARK-34856][FOLLOWUP][SQL] Remove dead code from AnsiCast.typeCheckFailureMessage #32004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Mar 30, 2021
HyukjinKwon
approved these changes
Mar 30, 2021
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
maropu
approved these changes
Mar 30, 2021
Member
Author
|
retest this please. |
Member
Author
|
^^^ I haven't sent this jenkins command for months...Have to do it since GA is slow now. |
MaxGekk
approved these changes
Mar 30, 2021
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
LGTM, I wonder don't we have any test for the "dead" code?
Member
Author
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
dongjoon-hyun
approved these changes
Mar 30, 2021
|
Test build #136718 has finished for PR 32004 at commit
|
Member
|
Merged to master |
|
Test build #136729 has finished for PR 32004 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After #31954, Array type is allowed to be cast as String type. So the customized conversion failure message branch from AnsiCast.typeCheckFailureMessage won't be reached anymore.
This PR is to remove the dead code.
Why are the changes needed?
Code clean up.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Just removing dead code.