-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-4329][WebUI] HistoryPage pagenation #3194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #23174 has started for PR 3194 at commit
|
|
Test build #23174 has finished for PR 3194 at commit
|
|
Test FAILed. |
|
I think the failure above is not related my changes. Jenkins, retest this please. |
|
retest this please. |
|
Test build #23187 has started for PR 3194 at commit
|
|
Test build #23187 has finished for PR 3194 at commit
|
|
Test PASSed. |
|
Yes!! I've been wanting to add this ever since 1.0. I'll take a look at this after the release. Also, I think +/- 2 pages is enough. Right now it looks a little cluttered. |
|
@andrewor14 Thanks for taking a look at this PR! |
|
Test build #23229 has started for PR 3194 at commit
|
|
Test build #23229 has finished for PR 3194 at commit
|
|
Test FAILed. |
|
Test build #23230 has started for PR 3194 at commit
|
|
Test build #23230 has finished for PR 3194 at commit
|
|
Test PASSed. |
|
Test build #23543 has started for PR 3194 at commit
|
|
Test build #23543 has finished for PR 3194 at commit
|
|
Test PASSed. |
|
Test build #23963 has started for PR 3194 at commit
|
|
Test build #23963 has finished for PR 3194 at commit
|
|
Test PASSed. |
|
Test build #24279 has started for PR 3194 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These could just be leftSideIndices and rightSideIndices
|
Hey just a few minor comments but the approach looks good. Thanks for working on this. |
|
@andrewor14 Thanks for all of your comments! I'll fix soon. |
|
Test build #24290 has started for PR 3194 at commit
|
|
Test build #24279 has finished for PR 3194 at commit
|
|
Test PASSed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plusOrMinux, I'll fix this when I merge don't worry
|
LGTM |
|
Test build #24290 has finished for PR 3194 at commit
|
|
Test PASSed. |
|
I'm merging this into master thanks. |
Current HistoryPage have links only to previous page or next page.
I suggest to add index to access history pages easily.
I implemented like following pics.
If there are many pages, current page +/- N pages, head page and last page are indexed.