Skip to content

[SPARK-34152][SQL][FOLLOW-UP] Global temp view's identifier should be correctly stored #31783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imback82 wants to merge 3 commits into from
Closed

[SPARK-34152][SQL][FOLLOW-UP] Global temp view's identifier should be correctly stored #31783

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b802a48
initial commit
imback82 Mar 9, 2021
e0dcec2
reorder
imback82 Mar 9, 2021
3d2ef7f
Address PR comments
imback82 Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ case class CreateViewCommand(
originalText))
} else {
TemporaryViewRelation(
prepareTemporaryViewFromDataFrame(name, aliasedPlan),
prepareTemporaryViewFromDataFrame(viewIdent, aliasedPlan),
Some(aliasedPlan))
}
catalog.createGlobalTempView(name.table, tableDefinition, overrideIfExists = replace)
Expand Down
18 changes: 18 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import org.apache.spark.sql._
import org.apache.spark.sql.catalyst.TableIdentifier
import org.apache.spark.sql.catalyst.analysis.NoSuchTableException
import org.apache.spark.sql.catalyst.parser.ParseException
import org.apache.spark.sql.catalyst.plans.logical.View
import org.apache.spark.sql.internal.SQLConf._
import org.apache.spark.sql.test.{SharedSparkSession, SQLTestUtils}

Expand Down Expand Up @@ -909,4 +910,21 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
}
}
}

test("SPARK-34152: global temp view's identifier should be correctly stored") {

@cloud-fan cloud-fan Mar 9, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move it to the new GlobalTempViewTestSuite? we should slowly move all the view tests to SQLViewTestSuite framework.

@dongjoon-hyun dongjoon-hyun Mar 9, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for @cloud-fan 's suggestion.

Seq(true, false).foreach { storeAnalyzed =>
withSQLConf(STORE_ANALYZED_PLAN_FOR_VIEW.key -> storeAnalyzed.toString) {
withGlobalTempView("v") {
sql("CREATE GLOBAL TEMPORARY VIEW v AS SELECT 1")
val globalTempDB = spark.sharedState.globalTempViewManager.database
val globalTempView = spark.sessionState.catalog.getGlobalTempView("v")
globalTempView match {
case Some(v: View) if v.isTempView =>
assert(v.desc.identifier == TableIdentifier("v", Some(globalTempDB)))
case _ => fail(s"Global temp view not found: $globalTempDB.v")
}
}
}
}
}
}