Change the initial iteration num of ruleExecutor from 1 to 0 #3174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
Author
|
i am new, but i think it is should be 0 not 1. |
Member
|
-1 This breaks the logic of the loop. For example if maxIterations is 1, now it will execute twice. |
Contributor
|
Agree with @srowen. @DoingDone9 Could you please elaborate on the reason why you think this change is necessary? |
Contributor
Author
|
@liancheng because log looks like "Fixed point reached for batch ${batch.name} after 3 iterations.", but it did 2 iterations really! I have pull request a other patch for this, #3180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the initial iteration num of ruleExecutor from 1 to 0.