[SPARK-33504][CORE][3.0] The application log in the Spark history server contains sensitive attributes should be redacted #31631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
dongjoon-hyun
approved these changes
Feb 24, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @viirya !
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #135405 has finished for PR 31631 at commit
|
Member
Author
|
Thanks. Merging to branch-3.0. |
viirya
added a commit
that referenced
this pull request
Feb 24, 2021
…ver contains sensitive attributes should be redacted ### What changes were proposed in this pull request? To make sure the sensitive attributes to be redacted in the history server log. This is the backport of original PR #30446. ### Why are the changes needed? We found the secure attributes like password in SparkListenerJobStart and SparkListenerStageSubmitted events would not been redated, resulting in sensitive attributes can be viewd directly. The screenshot can be viewed in the attachment of JIRA Spark-33504 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test. Closes #31631 from viirya/SPARK-33504-3.0. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: Liang-Chi Hsieh <[email protected]>
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
Mar 9, 2021
…ver contains sensitive attributes should be redacted ### What changes were proposed in this pull request? To make sure the sensitive attributes to be redacted in the history server log. This is the backport of original PR apache#30446. ### Why are the changes needed? We found the secure attributes like password in SparkListenerJobStart and SparkListenerStageSubmitted events would not been redated, resulting in sensitive attributes can be viewd directly. The screenshot can be viewed in the attachment of JIRA Spark-33504 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test. Closes apache#31631 from viirya/SPARK-33504-3.0. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: Liang-Chi Hsieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To make sure the sensitive attributes to be redacted in the history server log. This is the backport of original PR #30446.
Why are the changes needed?
We found the secure attributes like password in SparkListenerJobStart and SparkListenerStageSubmitted events would not been redated, resulting in sensitive attributes can be viewd directly.
The screenshot can be viewed in the attachment of JIRA Spark-33504
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test.