[SPARK-34500][DOCS][EXAMPLES] Replace symbol literals with $"" in examples and documents #31615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
HyukjinKwon
approved these changes
Feb 23, 2021
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Are there all instances? Looks good
|
Test build #135357 has finished for PR 31615 at commit
|
Member
|
Merged to master. |
Member
Author
I believe so. But I'll fix further if I find them in other places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR replaces all the occurrences of symbol literals (
'name) with string interpolation ($"name") in examples and documents.Why are the changes needed?
Symbol literals are used to represent columns in Spark SQL but the Scala community seems to remove
Symbolcompletely.As we discussed in #31569, first we should replacing symbol literals with
$"name"in user facing examples and documents.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Build docs.