Skip to content

[SPARK-34465][SQL] Rename v2 alter table exec nodes #31584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 3 commits into from
Closed

[SPARK-34465][SQL] Rename v2 alter table exec nodes #31584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03e8719
AlterTableAddPartition -> AddPartitionExec
MaxGekk Feb 18, 2021
411cf3a
AlterTableRenamePartitionExec -> RenamePartitionExec
MaxGekk Feb 18, 2021
dabc422
AlterTableDropPartitionExec -> DropPartitionExec
MaxGekk Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...urces/v2/AlterTableAddPartitionExec.scala → ...ion/datasources/v2/AddPartitionExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import org.apache.spark.sql.connector.catalog.{SupportsAtomicPartitionManagement
/**
* Physical plan node for adding partitions of table.
*/
case class AlterTableAddPartitionExec(
case class AddPartitionExec(
Copy link
Contributor

@cloud-fan cloud-fan Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we rename the logical plan as well? The logical plan for REAME is RenameTable as well.

Copy link
Member Author

@MaxGekk MaxGekk Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the PR #31596 @cloud-fan @imback82 @dongjoon-hyun Could you take a look at it.

table: SupportsPartitionManagement,
partSpecs: Seq[ResolvedPartitionSpec],
ignoreIfExists: Boolean,
Expand Down
6 changes: 3 additions & 3 deletions ...e/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ class DataSourceV2Strategy(session: SparkSession) extends Strategy with Predicat

case AlterTableAddPartition(
r @ ResolvedTable(_, _, table: SupportsPartitionManagement, _), parts, ignoreIfExists) =>
AlterTableAddPartitionExec(
AddPartitionExec(
table,
parts.asResolvedPartitionSpecs,
ignoreIfExists,
Expand All @@ -365,7 +365,7 @@ class DataSourceV2Strategy(session: SparkSession) extends Strategy with Predicat
parts,
ignoreIfNotExists,
purge) =>
AlterTableDropPartitionExec(
DropPartitionExec(
table,
parts.asResolvedPartitionSpecs,
ignoreIfNotExists,
Expand All @@ -374,7 +374,7 @@ class DataSourceV2Strategy(session: SparkSession) extends Strategy with Predicat

case AlterTableRenamePartition(
r @ ResolvedTable(_, _, table: SupportsPartitionManagement, _), from, to) =>
AlterTableRenamePartitionExec(
RenamePartitionExec(
table,
Seq(from).asResolvedPartitionSpecs.head,
Seq(to).asResolvedPartitionSpecs.head,
Expand Down
2 changes: 1 addition & 1 deletion ...rces/v2/AlterTableDropPartitionExec.scala → ...on/datasources/v2/DropPartitionExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import org.apache.spark.sql.connector.catalog.{SupportsAtomicPartitionManagement
/**
* Physical plan node for dropping partitions of table.
*/
case class AlterTableDropPartitionExec(
case class DropPartitionExec(
table: SupportsPartitionManagement,
partSpecs: Seq[ResolvedPartitionSpec],
ignoreIfNotExists: Boolean,
Expand Down
2 changes: 1 addition & 1 deletion ...es/v2/AlterTableRenamePartitionExec.scala → .../datasources/v2/RenamePartitionExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import org.apache.spark.sql.connector.catalog.SupportsPartitionManagement
/**
* Physical plan node for renaming a table partition.
*/
case class AlterTableRenamePartitionExec(
case class RenamePartitionExec(
table: SupportsPartitionManagement,
from: ResolvedPartitionSpec,
to: ResolvedPartitionSpec,
Expand Down