-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-34454][SQL] Mark legacy SQL configs as internal #31577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #135200 has finished for PR 31577 at commit
|
|
Test build #135226 has started for PR 31577 at commit |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Seems OK to me if we're saying nobody should be able to set it? but would we want to forbid it? |
If someone has a good reason to have a legacy conf as non internal, she/he can add an exception to the test. But I believe we should have a mechanism to catch the situation when someone adds "external" legacy config. |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changes were proposed in this pull request?
legacynamespace are marked as internal configs.Why are the changes needed?
Assuming that legacy SQL configs shouldn't be set by users in common cases. The purpose of such configs is to allow switching to old behavior in corner cases. So, the configs should be marked as internals.
Does this PR introduce any user-facing change?
Should not.
How was this patch tested?
By running new test: