Skip to content

Conversation

@xiao321
Copy link
Contributor

@xiao321 xiao321 commented Nov 7, 2014

数组下标越界

@xiao321
Copy link
Contributor Author

xiao321 commented Nov 7, 2014

the array index out of bounds

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Nov 7, 2014

LGTM but the title and description are not informative.

@xiao321
Copy link
Contributor Author

xiao321 commented Nov 7, 2014

oh,sorry,,,,when i run this command "bin/run-example org.apache.spark.examples.streaming.JavaCustomReceiver localhost 9999 ",this error is "java.lang.ClassNotFoundException: org.apache.spark.examples.arg.apache.spark.examples.streaming.JavaCustomReceiver",so i change the command like this "bin/run-example streaming.JavaCustomReceiver localhost 9999",this error is "java.lang.ArrayIndexOutOfBoundsException: 2".and then i view source,i find this"JavaReceiverInputDStream lines = ssc.receiverStream(new JavaCustomReceiver(args[1], Integer.parseInt(args[2])));",i think this should be changed to "JavaReceiverInputDStream lines = ssc.receiverStream(new JavaCustomReceiver(args[0], Integer.parseInt(args[1])));"
am i wrong??

------------------ 原始邮件 ------------------
发件人: "Sean Owen"[email protected];
发送时间: 2014年11月7日(星期五) 下午4:19
收件人: "apache/spark"[email protected];
抄送: "xiaobingxian"[email protected];
主题: Re: [spark] Update JavaCustomReceiver.java (#3153)

LGTM but the title and description are not informative.


Reply to this email directly or view it on GitHub.

@srowen
Copy link
Member

srowen commented Nov 7, 2014

No, I agree with the change. I'm saying that "Update JavaCustomReceiver" with no description is not a helpful title. Normally changes need a JIRA too, although this is so trivial that it may not.

@xiao321
Copy link
Contributor Author

xiao321 commented Nov 7, 2014

sorry,,,i am a beginner,,i will pay attention next time

------------------ 原始邮件 ------------------
发件人: "Sean Owen"[email protected];
发送时间: 2014年11月7日(星期五) 下午5:19
收件人: "apache/spark"[email protected];
抄送: "xiaobingxian"[email protected];
主题: Re: [spark] Update JavaCustomReceiver.java (#3153)

No, I agree with the change. I'm saying that "Update JavaCustomReceiver" with no description is not a helpful title. Normally changes need a JIRA too, although this is so trivial that it may not.


Reply to this email directly or view it on GitHub.

@tdas
Copy link
Contributor

tdas commented Nov 7, 2014

This is fine for now, I am merging this. Thank you very much for catching this.

@asfgit asfgit closed this in 7c9ec52 Nov 7, 2014
asfgit pushed a commit that referenced this pull request Nov 7, 2014
数组下标越界

Author: xiao321 <[email protected]>

Closes #3153 from xiao321/patch-1 and squashes the following commits:

0ed17b5 [xiao321] Update JavaCustomReceiver.java

(cherry picked from commit 7c9ec52)
Signed-off-by: Tathagata Das <[email protected]>
asfgit pushed a commit that referenced this pull request Nov 7, 2014
数组下标越界

Author: xiao321 <[email protected]>

Closes #3153 from xiao321/patch-1 and squashes the following commits:

0ed17b5 [xiao321] Update JavaCustomReceiver.java

(cherry picked from commit 7c9ec52)
Signed-off-by: Tathagata Das <[email protected]>
asfgit pushed a commit that referenced this pull request Nov 7, 2014
数组下标越界

Author: xiao321 <[email protected]>

Closes #3153 from xiao321/patch-1 and squashes the following commits:

0ed17b5 [xiao321] Update JavaCustomReceiver.java

(cherry picked from commit 7c9ec52)
Signed-off-by: Tathagata Das <[email protected]>
@xiao321 xiao321 deleted the patch-1 branch January 21, 2015 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants