Skip to content

[SPARK-34355][CORE][SQL][FOLLOWUP] Log commit time in all File Writer #31520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AngersZhuuuu wants to merge 6 commits into from
Closed

[SPARK-34355][CORE][SQL][FOLLOWUP] Log commit time in all File Writer #31520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
171cefd
Update FileBatchWrite.scala
AngersZhuuuu Feb 8, 2021
91d92f4
follow ccomment
AngersZhuuuu Feb 8, 2021
d3f7b34
Update SparkHadoopWriterUtils.scala
AngersZhuuuu Feb 8, 2021
555f5b4
Update SparkHadoopWriterUtils.scala
AngersZhuuuu Feb 8, 2021
6c3bdc6
revert change
AngersZhuuuu Feb 9, 2021
7b7d2bd
update
AngersZhuuuu Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,9 @@ object SparkHadoopWriter extends Logging {
iterator = iter)
})

committer.commitJob(jobContext, ret)
logInfo(s"Job ${jobContext.getJobID} committed.")
logInfo(s"Start to commit write Job ${jobContext.getJobID}.")
val (_, duration) = Utils.timeTakenMs { committer.commitJob(jobContext, ret) }
logInfo(s"Write Job ${jobContext.getJobID} committed. Elapsed time: $duration ms.")
} catch {
case cause: Throwable =>
logError(s"Aborting job ${jobContext.getJobID}.", cause)
Expand Down
6 changes: 4 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileBatchWrite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import org.apache.spark.internal.io.FileCommitProtocol
import org.apache.spark.sql.connector.write.{BatchWrite, DataWriterFactory, PhysicalWriteInfo, WriterCommitMessage}
import org.apache.spark.sql.execution.datasources.{WriteJobDescription, WriteTaskResult}
import org.apache.spark.sql.execution.datasources.FileFormatWriter.processStats
import org.apache.spark.util.Utils

class FileBatchWrite(
job: Job,
Expand All @@ -31,8 +32,9 @@ class FileBatchWrite(
extends BatchWrite with Logging {
override def commit(messages: Array[WriterCommitMessage]): Unit = {
val results = messages.map(_.asInstanceOf[WriteTaskResult])
committer.commitJob(job, results.map(_.commitMsg))
logInfo(s"Write Job ${description.uuid} committed.")
logInfo(s"Start to commit write Job ${description.uuid}.")
val (_, duration) = Utils.timeTakenMs { committer.commitJob(job, results.map(_.commitMsg)) }
logInfo(s"Write Job ${description.uuid} committed. Elapsed time: $duration ms.")

processStats(description.statsTrackers, results.map(_.summary.stats))
logInfo(s"Finished processing stats for write job ${description.uuid}.")
Expand Down