[SPARK-34346][CORE][SQL][3.1] io.file.buffer.size set by spark.buffer.size will override by loading hive-site.xml accidentally may cause perf regression#31482
Closed
yaooqinn wants to merge 2 commits intoapache:branch-3.1from
yaooqinn:SPARK-34346-31
Closed
[SPARK-34346][CORE][SQL][3.1] io.file.buffer.size set by spark.buffer.size will override by loading hive-site.xml accidentally may cause perf regression#31482yaooqinn wants to merge 2 commits intoapache:branch-3.1from yaooqinn:SPARK-34346-31
yaooqinn wants to merge 2 commits intoapache:branch-3.1from
yaooqinn:SPARK-34346-31
Conversation
… will override by loading hive-site.xml accidentally may cause perf regression In many real-world cases, when interacting with hive catalog through Spark SQL, users may just share the `hive-site.xml` for their hive jobs and make a copy to `SPARK_HOME`/conf w/o modification. In Spark, when we generate Hadoop configurations, we will use `spark.buffer.size(65536)` to reset `io.file.buffer.size(4096)`. But when we load the hive-site.xml, we may ignore this behavior and reset `io.file.buffer.size` again according to `hive-site.xml`. 1. The configuration priority for setting Hadoop and Hive config here is not right, while literally, the order should be `spark > spark.hive > spark.hadoop > hive > hadoop` 2. This breaks `spark.buffer.size` congfig's behavior for tuning the IO performance w/ HDFS if there is an existing `io.file.buffer.size` in hive-site.xml bugfix for configuration behavior and fix performance regression by that behavior change this pr restores silent user face change new tests Closes #31460 from yaooqinn/SPARK-34346. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Member
Author
|
cc @cloud-fan @maropu @HyukjinKwon here is the backport PR for 3.1, thanks |
|
Test build #134913 has finished for PR 31482 at commit
|
dongjoon-hyun
changed the title
Member
|
Thank you for making a backport, @yaooqinn . |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
cloud-fan
approved these changes
Feb 5, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #134917 has finished for PR 31482 at commit
|
Member
Author
|
retest this please |
HyukjinKwon
approved these changes
Feb 5, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #134932 has finished for PR 31482 at commit
|
cloud-fan
pushed a commit
that referenced
this pull request
Feb 5, 2021
….size will override by loading hive-site.xml accidentally may cause perf regression backport #31460 to branch 3.1 ### What changes were proposed in this pull request? In many real-world cases, when interacting with hive catalog through Spark SQL, users may just share the `hive-site.xml` for their hive jobs and make a copy to `SPARK_HOME`/conf w/o modification. In Spark, when we generate Hadoop configurations, we will use `spark.buffer.size(65536)` to reset `io.file.buffer.size(4096)`. But when we load the hive-site.xml, we may ignore this behavior and reset `io.file.buffer.size` again according to `hive-site.xml`. 1. The configuration priority for setting Hadoop and Hive config here is not right, while literally, the order should be `spark > spark.hive > spark.hadoop > hive > hadoop` 2. This breaks `spark.buffer.size` congfig's behavior for tuning the IO performance w/ HDFS if there is an existing `io.file.buffer.size` in hive-site.xml ### Why are the changes needed? bugfix for configuration behavior and fix performance regression by that behavior change ### Does this PR introduce _any_ user-facing change? this pr restores silent user face change ### How was this patch tested? new tests Closes #31482 from yaooqinn/SPARK-34346-31. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Contributor
|
thanks, merging to 3.1! |
Contributor
|
@yaooqinn can you open a backport PR for 3.0? It conflicts. thanks! |
Member
Author
|
OK. I got it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #31460 to branch 3.1
What changes were proposed in this pull request?
In many real-world cases, when interacting with hive catalog through Spark SQL, users may just share the
hive-site.xmlfor their hive jobs and make a copy toSPARK_HOME/conf w/o modification. In Spark, when we generate Hadoop configurations, we will usespark.buffer.size(65536)to resetio.file.buffer.size(4096). But when we load the hive-site.xml, we may ignore this behavior and resetio.file.buffer.sizeagain according tohive-site.xml.The configuration priority for setting Hadoop and Hive config here is not right, while literally, the order should be
spark > spark.hive > spark.hadoop > hive > hadoopThis breaks
spark.buffer.sizecongfig's behavior for tuning the IO performance w/ HDFS if there is an existingio.file.buffer.sizein hive-site.xmlWhy are the changes needed?
bugfix for configuration behavior and fix performance regression by that behavior change
Does this PR introduce any user-facing change?
this pr restores silent user face change
How was this patch tested?
new tests