Skip to content

[SPARK-34371][SQL][TESTS] Run the datetime rebasing tests for Parquet datasource v1 and v2#31478

Closed
MaxGekk wants to merge 1 commit intoapache:masterfrom
MaxGekk:rebase-tests-dsv1-and-dsv2
Closed

[SPARK-34371][SQL][TESTS] Run the datetime rebasing tests for Parquet datasource v1 and v2#31478
MaxGekk wants to merge 1 commit intoapache:masterfrom
MaxGekk:rebase-tests-dsv1-and-dsv2

Conversation

@MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented Feb 4, 2021

What changes were proposed in this pull request?

Extract the date/timestamps rebasing tests from ParquetIOSuite to ParquetRebaseDatetimeSuite to run them for both DSv1 and DSv2 implementations of Parquet datasource.

Why are the changes needed?

To improve test coverage.

Does this PR introduce any user-facing change?

No

How was this patch tested?

By running new test suites:

$ build/sbt "sql/test:testOnly *ParquetRebaseDatetimeV2Suite"
$ build/sbt "sql/test:testOnly *ParquetRebaseDatetimeV1Suite"
$ build/sbt "sql/test:testOnly *ParquetIOSuite"

@github-actions github-actions bot added the SQL label Feb 4, 2021
@SparkQA
Copy link

SparkQA commented Feb 4, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39477/

@SparkQA
Copy link

SparkQA commented Feb 4, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39477/

@SparkQA
Copy link

SparkQA commented Feb 5, 2021

Test build #134894 has finished for PR 31478 at commit 0aacb9b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class ParquetRebaseDatetimeV1Suite extends ParquetRebaseDatetimeSuite
  • class ParquetRebaseDatetimeV2Suite extends ParquetRebaseDatetimeSuite

@MaxGekk
Copy link
Member Author

MaxGekk commented Feb 5, 2021

@cloud-fan @gengliangwang @HyukjinKwon Could you review this PR.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in ee11a8f Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants