Skip to content
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.spark.sql.connector;

import org.apache.spark.annotation.Evolving;

/**
* A custom metric.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a public API, it would be great to add more information to explain how to use APIs as a developer. For example,

  • If I define my own CustomMetric, how does Spark use it?
  • If I define a metric type that doesn't support sum, for example, measure the executor jvm heap size, how does Spark handle it?
  • If my PartitionReaderWithMetrics returns metrics for a partition, will Spark combine them for partitions of a Spark job?
  • In the streaming case, how does Spark combine metrics from different micro batches?
  • If I would like to report metrics in driver, how do I do it?

I feel you might need to build an interface similar to the private SQLMetric.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add more information to the comment.

Basically I will add a few metric classes based on CustomMetric. They are correspond to sum, size, timing metrics in SQLMetric.

*
* @since 3.2.0
*/
@Evolving
public interface CustomMetric {
/**
* Returns the name of custom metric.
*/
String name();

/**
* Returns the description of custom metric.
*/
String description();
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.spark.sql.connector;

import org.apache.spark.annotation.Evolving;

/**
* A custom metric that reports a long value.
*
* @since 3.2.0
*/
@Evolving
public interface LongMetric extends CustomMetric {
/**
* Returns the value of custom metric.
*/
long value();
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.spark.sql.connector;

import org.apache.spark.annotation.Evolving;

/**
* Data sources can implement this interface to
* report supported custom metrics to Spark in read/write path.
*
* @since 3.2.0
*/
@Evolving
public interface SupportsReportMetrics {

/**
* Returns an array of supported custom metrics with name and description.
* By default it returns empty array.
*/
default CustomMetric[] supportedCustomMetrics() {
CustomMetric[] NO_METRICS = {};
return NO_METRICS;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.spark.sql.connector.read;

import org.apache.spark.annotation.Evolving;
import org.apache.spark.sql.connector.CustomMetric;

/**
* A mix in interface for {@link PartitionReader}. Partition reader can this interface to
* report custom metrics to Spark.
*
* @since 3.2.0
*/
@Evolving
public interface PartitionReaderWithMetrics<T> extends PartitionReader<T> {

/**
* Returns an array of custom metrics. By default it returns empty array.
*/
default CustomMetric[] getCustomMetrics() {
CustomMetric[] NO_METRICS = {};
return NO_METRICS;
}
}