[SPARK-34350][SQL][TESTS] replace withTimeZone defined in OracleIntegrationSuite with DateTimeTestUtils.withDefaultTimeZone#31465
Closed
sarutak wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #134850 has finished for PR 31465 at commit
|
srowen
approved these changes
Feb 4, 2021
maropu
approved these changes
Feb 5, 2021
Member
maropu
left a comment
maropu
left a comment
There was a problem hiding this comment.
okay, I've checked OracleIntegrationSuite can pass.
Member
|
Thanks! Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR replaces
withTimeZonedefined and used inOracleIntegrationSuitewithDateTimeTestUtils.withDefaultTimeZonewhich is defined as a utility method.Why are the changes needed?
Both methods are semantically the same so it might be better to use the utility one.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
OracleIntegrationSuitepasses.