[SPARK-31768][ML][FOLLOWUP] add getMetrics in Evaluators: cleanup #31334
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeichenXu123
approved these changes
Jan 26, 2021
Contributor
WeichenXu123
left a comment
WeichenXu123
left a comment
There was a problem hiding this comment.
LGTM. Need merge to master/spark3.1
|
Test build #134469 has finished for PR 31334 at commit
|
WeichenXu123
pushed a commit
that referenced
this pull request
Jan 26, 2021
### What changes were proposed in this pull request? 1, make `silhouette` a method; 2, change return type of `setDistanceMeasure` to `this.type`; ### Why are the changes needed? see comments in #28590 ### Does this PR introduce _any_ user-facing change? No, 3.1 has not been released ### How was this patch tested? existing testsuites Closes #31334 from zhengruifeng/31768-followup. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Weichen Xu <[email protected]> (cherry picked from commit cb37c96) Signed-off-by: Weichen Xu <[email protected]>
Contributor
|
Merged to master/branch-3.1 |
skestle
pushed a commit
to skestle/spark
that referenced
this pull request
Feb 3, 2021
### What changes were proposed in this pull request? 1, make `silhouette` a method; 2, change return type of `setDistanceMeasure` to `this.type`; ### Why are the changes needed? see comments in apache#28590 ### Does this PR introduce _any_ user-facing change? No, 3.1 has not been released ### How was this patch tested? existing testsuites Closes apache#31334 from zhengruifeng/31768-followup. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, make
silhouettea method;2, change return type of
setDistanceMeasuretothis.type;Why are the changes needed?
see comments in #28590
Does this PR introduce any user-facing change?
No, 3.1 has not been released
How was this patch tested?
existing testsuites