Skip to content

Conversation

@MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented Jan 25, 2021

What changes were proposed in this pull request?

Forward port changes in tests from #31326.

Why are the changes needed?

This fixes a test failure.

Does this PR introduce any user-facing change?

No

How was this patch tested?

By running the affected test suite:

$ build/sbt -Phive -Phive-thriftserver "test:testOnly *CatalogedDDLSuite"

@MaxGekk MaxGekk changed the title [SPARK-34203][SQL][3.1] Forward port tests for null partition values [SPARK-34203][SQL][TESTS][3.1] Forward port tests for null partition values Jan 25, 2021
@github-actions github-actions bot added the SQL label Jan 25, 2021
@dongjoon-hyun
Copy link
Member

Thank you, @MaxGekk !

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-34203][SQL][TESTS][3.1] Forward port tests for null partition values [SPARK-34203][SQL][TESTS][3.1] Fix null partition values UT failure Jan 25, 2021
@dongjoon-hyun
Copy link
Member

BTW, @MaxGekk . I revised the PR title because we cannot use forward-port because #31326 is not merged yet. This is a normal follow-up for the broken UT during backport.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-34203][SQL][TESTS][3.1] Fix null partition values UT failure [SPARK-34203][SQL][TESTS][3.1][FOLLOWUP] Fix null partition values UT failure Jan 25, 2021
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. This is a test-only update and I verified the tests manually.
Merged to branch-3.1 to recover the branch.

dongjoon-hyun pushed a commit that referenced this pull request Jan 25, 2021
… failure

### What changes were proposed in this pull request?
Forward port changes in tests from #31326.

### Why are the changes needed?
This fixes a test failure.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
By running the affected test suite:
```
$ build/sbt -Phive -Phive-thriftserver "test:testOnly *CatalogedDDLSuite"
```

Closes #31331 from MaxGekk/insert-overwrite-null-part-3.1.

Authored-by: Max Gekk <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
@SparkQA
Copy link

SparkQA commented Jan 25, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39049/

@SparkQA
Copy link

SparkQA commented Jan 25, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39049/

@SparkQA
Copy link

SparkQA commented Jan 26, 2021

Test build #134462 has finished for PR 31331 at commit 0d42da4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants