[SPARK-30682][R][SQL][FOLLOW-UP] Keep the name similar with Scala side in higher order functions#31226
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-30682][R][SQL][FOLLOW-UP] Keep the name similar with Scala side in higher order functions#31226HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@dongjoon-hyun and @viirya, would you mind taking a quick look please? |
viirya
approved these changes
Jan 18, 2021
Member
|
lgtm |
|
Test build #134176 has finished for PR 31226 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
Member
Author
|
Merged to master and branch-3.1. |
HyukjinKwon
added a commit
that referenced
this pull request
Jan 18, 2021
…e in higher order functions ### What changes were proposed in this pull request? This PR is a followup of #27433. It fixes the naming to match with Scala side, and this is similar with #31062. Note that: - there are a bit of inconsistency already e.g.) `x`, `y` in SparkR and they are documented together for doc deduplication. This part I did not change but the name `zero` vs `initialValue` looks unnecessary. - such naming matching seems already pretty common in SparkR. ### Why are the changes needed? To make the usage similar with Scala side, and for consistency. ### Does this PR introduce _any_ user-facing change? No, this is not released yet. ### How was this patch tested? GitHub Actions and Jenkins build will test it out. Also, I manually tested: ```r > df <- select(createDataFrame(data.frame(id = 1)),expr("CAST(array(1.0, 2.0, -3.0, -4.0) AS array<double>) xs")) > collect(select(df, array_aggregate("xs", initialValue = lit(0.0), merge = function(x, y) otherwise(when(x > y, x), y)))) aggregate(xs, 0.0, lambdafunction(CASE WHEN (x > y) THEN x ELSE y END, x, y), lambdafunction(id, id)) 1 2 ``` Closes #31226 from HyukjinKwon/SPARK-30682. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit b5bdbf2) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Member
|
+1, late LGTM. |
skestle
pushed a commit
to skestle/spark
that referenced
this pull request
Feb 3, 2021
…e in higher order functions ### What changes were proposed in this pull request? This PR is a followup of apache#27433. It fixes the naming to match with Scala side, and this is similar with apache#31062. Note that: - there are a bit of inconsistency already e.g.) `x`, `y` in SparkR and they are documented together for doc deduplication. This part I did not change but the name `zero` vs `initialValue` looks unnecessary. - such naming matching seems already pretty common in SparkR. ### Why are the changes needed? To make the usage similar with Scala side, and for consistency. ### Does this PR introduce _any_ user-facing change? No, this is not released yet. ### How was this patch tested? GitHub Actions and Jenkins build will test it out. Also, I manually tested: ```r > df <- select(createDataFrame(data.frame(id = 1)),expr("CAST(array(1.0, 2.0, -3.0, -4.0) AS array<double>) xs")) > collect(select(df, array_aggregate("xs", initialValue = lit(0.0), merge = function(x, y) otherwise(when(x > y, x), y)))) aggregate(xs, 0.0, lambdafunction(CASE WHEN (x > y) THEN x ELSE y END, x, y), lambdafunction(id, id)) 1 2 ``` Closes apache#31226 from HyukjinKwon/SPARK-30682. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #27433. It fixes the naming to match with Scala side, and this is similar with #31062.
Note that:
x,yin SparkR and they are documented together for doc deduplication. This part I did not change but the namezerovsinitialValuelooks unnecessary.Why are the changes needed?
To make the usage similar with Scala side, and for consistency.
Does this PR introduce any user-facing change?
No, this is not released yet.
How was this patch tested?
GitHub Actions and Jenkins build will test it out.
Also, I manually tested: