[SPARK-33796][DOCS][FOLLOWUP] Tweak the width of left-menu of Spark SQL Guide #31091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #133834 has finished for PR 31091 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
srowen
approved these changes
Jan 8, 2021
Member
|
I'm going to merge to master, and 3.1 as well, because the original JIRA was resolved for 3.1 and this is so minor. |
srowen
pushed a commit
that referenced
this pull request
Jan 8, 2021
…QL Guide ### What changes were proposed in this pull request? This PR tweaks the width of left-menu of Spark SQL Guide. When I view the Spark SQL Guide with browsers on macOS, the title `Spark SQL Guide` looks prettily. But I often use Pop!_OS, an Ubuntu variant, and the title is overlapped with browsers on it.  After this change, the title is no longer overlapped.  ### Why are the changes needed? For the pretty layout. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Built the document with `cd docs && SKIP_API=1 jekyll build` and confirmed the layout. Closes #31091 from sarutak/modify-layout-sparksql-guide. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit 023eba2) Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR tweaks the width of left-menu of Spark SQL Guide.
When I view the Spark SQL Guide with browsers on macOS, the title
Spark SQL Guidelooks prettily.But I often use Pop!_OS, an Ubuntu variant, and the title is overlapped with browsers on it.
After this change, the title is no longer overlapped.
Why are the changes needed?
For the pretty layout.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Built the document with
cd docs && SKIP_API=1 jekyll buildand confirmed the layout.