Skip to content

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Jan 8, 2021

What changes were proposed in this pull request?

This PR fixes an incorrect unicode literal test in ParserUtilsSuite.
In that suite, string literals in queries have unicode escape characters like \u7328 but the backslash should be escaped because
the queriy strings are given as Java strings.

Why are the changes needed?

Correct the test.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Run ParserUtilsSuite and it passed.

@github-actions github-actions bot added the SQL label Jan 8, 2021
@SparkQA
Copy link

SparkQA commented Jan 8, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38414/

@SparkQA
Copy link

SparkQA commented Jan 8, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38414/

@SparkQA
Copy link

SparkQA commented Jan 8, 2021

Test build #133825 has finished for PR 31088 at commit 0102b40.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jan 8, 2021

Merged to master

@srowen srowen closed this in 0781ed4 Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants