Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 7, 2021

What changes were proposed in this pull request?

This PR aims to move OrcEncryptionSuite from sql/core to sql/hive module.

Why are the changes needed?

Currently, OrcEncryptionSuite passed in Jenkins and locally with build/sbt "sql/testOnly *.OrcEncryptionSuite"
while it fails at GitHub Action with dev/run-tests.py.

Does this PR introduce any user-facing change?

No. This is a test dependency.

How was this patch tested?

Pass the GitHub Action.

@dongjoon-hyun dongjoon-hyun marked this pull request as draft January 7, 2021 01:43
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-34029][SQL][TESTS][FOLLOWUP] Add hadoop-client test dependency explicitly [SPARK-34029][SQL][TESTS][FOLLOWUP] Add hadoop-common test dependency explicitly Jan 7, 2021
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-34029][SQL][TESTS][FOLLOWUP] Add hadoop-common test dependency explicitly [SPARK-34029][SQL][TESTS][FOLLOWUP] Add hadoop-common provided dependency explicitly Jan 7, 2021
@SparkQA
Copy link

SparkQA commented Jan 7, 2021

Test build #133760 has finished for PR 31076 at commit ccb45af.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 7, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38360/

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-34029][SQL][TESTS][FOLLOWUP] Add hadoop-common provided dependency explicitly [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Add hadoop-common provided dependency explicitly Jan 7, 2021
@dongjoon-hyun
Copy link
Member Author

Retest this please

@SparkQA

This comment has been minimized.

@SparkQA
Copy link

SparkQA commented Jan 7, 2021

Test build #133764 has finished for PR 31076 at commit b00a3ec.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Add hadoop-common provided dependency explicitly [SPARK-34029][SQL][TESTS][FOLLOWUP][test-maven] Move OrcEncryptionSuite to hive module Jan 7, 2021
@SparkQA
Copy link

SparkQA commented Jan 7, 2021

Test build #133772 has finished for PR 31076 at commit 095b595.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 7, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38364/

@dongjoon-hyun
Copy link
Member Author

The CliClient failure in hive-thriftserver module is irrelevant.

@SparkQA
Copy link

SparkQA commented Jan 7, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38364/

@dongjoon-hyun
Copy link
Member Author

I'll revert the original PR because it seems to take more time. Sorry about the trouble.

@HyukjinKwon
Copy link
Member

It's alright. Thanks for taking a look for this @dongjoon-hyun.

@SparkQA
Copy link

SparkQA commented Jan 7, 2021

Test build #133775 has finished for PR 31076 at commit 46aa723.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-ENC-GHA branch January 7, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants