[SPARK-33806][SQL][FOLLOWUP] Fold RepartitionExpression num partition should check if partition expression is empty #31074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Kubernetes integration test starting |
dongjoon-hyun
approved these changes
Jan 7, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @ulysses-you .
The GitHub Action failure is irrevant.
Contributor
Author
|
thanks @dongjoon-hyun |
|
Kubernetes integration test status failure |
|
Test build #133758 has finished for PR 31074 at commit
|
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
… should check if partition expression is empty
Add check partition expressions is empty.
We should keep `spark.range(1).hint("REPARTITION_BY_RANGE")` has default shuffle number instead of 1.
Yes.
Add test.
Closes apache#31074 from ulysses-you/SPARK-33806-FOLLOWUP.
Authored-by: ulysses-you <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit f9daf03)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add check partition expressions is empty.
Why are the changes needed?
We should keep
spark.range(1).hint("REPARTITION_BY_RANGE")has default shuffle number instead of 1.Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
Add test.