[SPARK-34032][SS]Add truststore and keystore type config possibility for Kafka delegation token #31070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for Kafka delegation token
|
Test build #133753 has finished for PR 31070 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
viirya
approved these changes
Jan 6, 2021
Member
|
cc @HeartSaVioR |
Contributor
|
Triggering Jenkins / Github Action. I'll merge once test passes. |
Contributor
|
retest this, please |
|
Test build #133829 has finished for PR 31070 at commit
|
Contributor
|
OK test passed. Merging to master. |
Contributor
|
Thanks @gaborgsomogyi for the contribution! I merged this to master. |
Contributor
Author
|
Thanks you guys taking care! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Kafka delegation token is obtained with
AdminClientwhere security settings can be set. Keystore and trustrore type however can't be set. In this PR I've added these new configurations. This can be useful when the type is different. A good example is to make Spark FIPS compliant where the default JKS is not accepted.Why are the changes needed?
Missing configurations.
Does this PR introduce any user-facing change?
Yes, adding 2 additional config parameters.
How was this patch tested?
Existing + modified unit tests + simple Kafka to Kafka app on cluster.